Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodeGroup judy IsNil to avoid crashed #2149

Merged
merged 1 commit into from
Jul 23, 2019
Merged

nodeGroup judy IsNil to avoid crashed #2149

merged 1 commit into from
Jul 23, 2019

Conversation

yan234280533
Copy link

nodeGroup judy IsNil to avoid crashed

@k8s-ci-robot
Copy link
Contributor

Welcome @yan234280533!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2019
@k8s-ci-robot k8s-ci-robot requested review from losipiuk and piosz June 30, 2019 09:35
losipiuk
losipiuk reviewed Jul 1, 2019
View reviewed changes
cluster-autoscaler/clusterstate/clusterstate.go
@@ -585,7 +585,7 @@ func (csr *ClusterStateRegistry) updateReadinessStats(currentTime time.Time) {
klog.Warningf("Failed to get nodegroup for %s: %v", unregistered.Node.Name, errNg)
continue
}
if nodeGroup == nil {
if nodeGroup == nil || reflect.ValueOf(nodeGroup).IsNil() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you actually encounter this? I think the cloudprovider which returned nil wrapped in an interface should be fixed. Not this place.

Copy link
Author

@yan234280533 yan234280533 Jul 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually encounter this. And i found other places judied the value were nil except here.

mwielgus
mwielgus approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019
@mwielgus
Copy link
Contributor

Let's merge this to avoid buggy cloud providers to crash CA. This is lesser evil :/.

@k8s-ci-robot k8s-ci-robot merged commit 952fdfd into kubernetes:master Jul 23, 2019
@danielmellado danielmellado mentioned this pull request Oct 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losipiuk losipiuk losipiuk left review comments

@mwielgus mwielgus mwielgus approved these changes

@piosz piosz Awaiting requested review from piosz

Assignees

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yan234280533 @k8s-ci-robot @mwielgus @losipiuk